Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

danken at redhat.com danken at redhat.com
Tue Jun 17 13:35:52 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Move multipath configuration to vdsm-tool configurator
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/26123/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 154:         else:
Line 155:             raise
Line 156: 
Line 157: 
Line 158: def rotateFiles(directory, prefixName, gen, cp=False, persist=False):
> good to have rotate to old conf files. +1 for use it in configurator (maybe
The benefit of commenting out is that we:

* don't need this awfully-implemented function out of storage
* already have the mechanism to uncomment the file and return it to original content upon uninstall and during upgrade.
Line 159:     logging.debug("dir: %s, prefixName: %s, versions: %s" %
Line 160:                  (directory, prefixName, gen))
Line 161:     gen = int(gen)
Line 162:     files = os.listdir(directory)


Line 906:     else:
Line 907:         return OSName.UNKNOWN
Line 908: 
Line 909: 
Line 910: def isOvirtNode():
please rebase on top of http://gerrit.ovirt.org/28486 ; in any case, such changes belong to a separate patch.
Line 911:     return getos() in (OSName.RHEVH, OSName.OVIRT)
Line 912: 
Line 913: 
Line 914: def persistFile(name):


-- 
To view, visit http://gerrit.ovirt.org/26123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40f802477e39000c5cae01a496ac2d9f879ebfa8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list