Change in vdsm[master]: vdsm: add support for hostdev passthrough
mpoledni at redhat.com
mpoledni at redhat.com
Tue Jun 17 10:48:37 UTC 2014
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
......................................................................
Patch Set 15:
(2 comments)
http://gerrit.ovirt.org/#/c/22462/15/vdsm/caps.py
File vdsm/caps.py:
Line 505: # we can still report back the name
Line 506: pass
Line 507: except IndexError:
Line 508: # should device not have a name, there is nothing engine could send
Line 509: # back that we could use to uniquely identify and initiate a device
> Then please consider to add a warning here.
This is in the "should not ever happen" class, and it's occurrence would probably be spotted way sooner - in this case the warning would be irrelevant
Line 510: continue
Line 511:
Line 512: if capability in supportedDevices:
Line 513: devices.append(dev)
http://gerrit.ovirt.org/#/c/22462/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4569:
Line 4570: # we have to manually reattach passthrough devices
Line 4571: for dev in self._devices[HOSTDEV_DEVICES]:
Line 4572: self.log.debug('Retaching device %s', dev.name)
Line 4573: dev._nodeptr.reAttach()
> We have the same snippet twice, so we reached the threshold for moving this
You have actually spotted a code that happened by mistake, it only belongs here.
Line 4574:
Line 4575: hooks.before_vm_destroy(self._lastXMLDesc, self.conf)
Line 4576: self.destroyed = True
Line 4577:
--
To view, visit http://gerrit.ovirt.org/22462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list