Change in vdsm[master]: tests: type checking for primitive types

vfeenstr at redhat.com vfeenstr at redhat.com
Tue Jun 17 10:27:03 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: tests: type checking for primitive types
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/28802/2/tests/vmApiTests.py
File tests/vmApiTests.py:

Line 63: isinstance
I think that rather should check for basestring, some values can be unicode.


-- 
To view, visit http://gerrit.ovirt.org/28802
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8463b5148e710bbb3b336d4b79fae183a71d89da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list