Change in vdsm[master]: sd: make preallocate optional in volume validation

danken at redhat.com danken at redhat.com
Tue Jun 17 09:40:30 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: sd: make preallocate optional in volume validation
......................................................................


sd: make preallocate optional in volume validation

In the current effort to move to the new storage API the preallocate
option may be omitted and therefore should not be validated.

Relates-To: http://bugzilla.redhat.com/show_bug.cgi?id=1097843
Change-Id: Ide89098b404e992678441d4b6f996ff203e055f0
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28129
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/blockSD.py
M vdsm/storage/hsm.py
M vdsm/storage/sd.py
M vdsm/storage/volume.py
4 files changed, 13 insertions(+), 9 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Federico Simoncelli: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28129
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide89098b404e992678441d4b6f996ff203e055f0
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list