Change in vdsm[master]: domainMonitor: Extract domain monitoring methods

nsoffer at redhat.com nsoffer at redhat.com
Tue Jun 17 06:58:55 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: domainMonitor: Extract domain monitoring methods
......................................................................


Patch Set 4:

This version unify methods for producing domain and setting iso info, so the function have no logic, and they are called only if needed, like all other functions. This make these functions candicates for cancellation point (see next patch).

Since the logic for these function is having uninitialized instance variable, I did not create _shouldProduceDomain and _shouldSetIsoInfo methods, as it seems to obscure the code, and it is not expected the change.

-- 
To view, visit http://gerrit.ovirt.org/27714
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87ac6a82e560bc4360a3bc3f6f6fd94623678cc2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list