Change in vdsm[master]: domainMonitor: Stop domain monitors concurrently

nsoffer at redhat.com nsoffer at redhat.com
Tue Jun 17 06:49:52 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: domainMonitor: Stop domain monitors concurrently
......................................................................


Patch Set 5:

Changes:
- Ensure that a monitor invokes its finish callback even if exceptions are raised
- Remove redundant removal of monitors in waitForMonitor
- Log warning if monitor does not exits when removed
- Fix incorrect error handling when stopping monitoring - previous code could hide KeyError inside DomainMonitor.stop()
- Fix incorrect error handling when waiting for monit - previous code could hide KeyError inside DomainMonitor.wait()
- Fix ugliness calling waitForMonitor in stopMonitoring, now simply invoke monitor.wait()

-- 
To view, visit http://gerrit.ovirt.org/27573
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12f137f1ed055316767e1a9384d8982720bc564
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list