Change in vdsm[master]: virt: add support to cancel the core dump of a VM.

fromani at redhat.com fromani at redhat.com
Tue Jun 17 06:27:06 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: add support to cancel the core dump of a VM.
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.ovirt.org/#/c/11130/15/vdsm/virt/coredump.py
File vdsm/virt/coredump.py:

Line 49:         if postAction:
Line 50:             self.flags |= CoreDumpThread.postActionFlags[postAction]
Line 51:         if bypassCache:
Line 52:             self.flags |= libvirt.VIR_DUMP_BYPASS_CACHE
Line 53:         self.memoryOnly = memoryOnly
> Looks like is no longer needed. Will remove.
Sorry, talked too early. It is used in vm.py in coreDumpCancel as part of the early checks.
Line 54:         if memoryOnly:
Line 55:             self.flags |= libvirt.VIR_DUMP_MEMORY_ONLY
Line 56: 
Line 57:         self.status = {'code': CoreDumpThread.Status.NONE,


-- 
To view, visit http://gerrit.ovirt.org/11130
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list