Change in vdsm[master]: vdsm: docstring update

ybronhei at redhat.com ybronhei at redhat.com
Mon Jun 16 16:23:29 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: docstring update
......................................................................


Patch Set 2: Code-Review-1

(5 comments)

few typos

http://gerrit.ovirt.org/#/c/28806/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-06-16 13:55:08 +0200
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2014-06-16 14:14:32 +0200
Line 6: 
Line 7: vdsm: docstring update
just put on title - adding docstring to MultiProtocolAcceptor and ConnectedTcpServer
Line 8: 
Line 9: MultiProtocolAcceptor and ConnectedTCPServer now have docstring
Line 10: explanation how they work.
Line 11: 


http://gerrit.ovirt.org/#/c/28806/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 232: 
Line 233: class ConnectedTCPServer(SocketServer.TCPServer, object):
Line 234: 
Line 235:     """
Line 236:     It provides ability to add connected sockets for TCPServer to
ConnectedTCPServer provides ...
Line 237:     process. New connections are put to the gueue and TCPServers
Line 238:     gets them by calling get_request method.
Line 239:     """
Line 240: 


Line 233: class ConnectedTCPServer(SocketServer.TCPServer, object):
Line 234: 
Line 235:     """
Line 236:     It provides ability to add connected sockets for TCPServer to
Line 237:     process. New connections are put to the gueue and TCPServers
s/gueue/queue
Line 238:     gets them by calling get_request method.
Line 239:     """
Line 240: 
Line 241:     def __init__(self, RequestHandlerClass):


http://gerrit.ovirt.org/#/c/28806/2/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:

Line 32: 
Line 33: 
Line 34: class MultiProtocolAcceptor:
Line 35:     """
Line 36:     Acceptor opens a single socket to listen on incoming connections.
MultiProtocolAcceptor opens ..
Line 37:     It handles ssh handshake and waits for initial data to arrive.
Line 38:     When the data is received it peaks first few bites and tries to
Line 39:     detect which protocol is used.
Line 40:     Protocol detection is done by detectors which are provided by


Line 35:     """
Line 36:     Acceptor opens a single socket to listen on incoming connections.
Line 37:     It handles ssh handshake and waits for initial data to arrive.
Line 38:     When the data is received it peaks first few bites and tries to
Line 39:     detect which protocol is used.
s/bites/bytes
Line 40:     Protocol detection is done by detectors which are provided by
Line 41:     calling add_detector. There are currently two protocol detectors.
Line 42:     One for already existing xmlrpc and the other for new jsonrpc over
Line 43:     stomp.


-- 
To view, visit http://gerrit.ovirt.org/28806
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list