Change in vdsm[master]: configurator.py: Node unpersist must be called before removi...

mtayer at redhat.com mtayer at redhat.com
Mon Jun 16 15:04:51 UTC 2014


mooli tayer has posted comments on this change.

Change subject: configurator.py: Node unpersist must be called before removing a file.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28821/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 320:         delete a file if it exists.
Line 321:         """
Line 322:         try:
Line 323:             if utils.isOvirtNode():
Line 324:                 NodeCfg().unpersist(content['path'])
On verification I will need to test if unpersist()
 is ok with non existing files.
Line 325: 
Line 326:             os.unlink(content['path'])
Line 327:         except OSError as e:
Line 328:             if e.errno != errno.ENOENT:


-- 
To view, visit http://gerrit.ovirt.org/28821
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7226b792c904ff8ca35054e20b85be707c080b49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list