Change in vdsm[master]: Add API.VM.setIoTune

fromani at redhat.com fromani at redhat.com
Mon Jun 16 14:55:46 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: Add API.VM.setIoTune
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Perhaps I'm missing something but I don't see where this is actually bound to XML-RPC/JSON-RPC

-1 just for visibility

http://gerrit.ovirt.org/#/c/28714/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3735:             device_path = io_tune_change.get('path', None)
Line 3736:             io_tune = io_tune_change['ioTune']
Line 3737: 
Line 3738:             # Find the proper device object
Line 3739:             for device in self._devices:
Maybe lookupDeviceByPath or findDriveByName can be of some help here.

Most likely you can save some cycles by narrowing down the research field to

self._devices[DISK_DEVICES]
Line 3740:                 if ((device.name == device_name
Line 3741:                     or device.get("path") == device_path)
Line 3742:                         and isVdsmImage(device)):
Line 3743:                     found_device = device


-- 
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bd48f13311ad2efc4241117a777ca3400c259ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list