Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...

mtayer at redhat.com mtayer at redhat.com
Mon Jun 16 14:34:52 UTC 2014


mooli tayer has posted comments on this change.

Change subject: configurator.py: fix _removeFile to do as described in it's doc string.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/28782/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 318:         """
Line 319:         delete a file if it exists.
Line 320:         """
Line 321:         if os.path.exists(content['path']):
Line 322:             utils.rmFile(content['path'])
> I do believe this order is not correct.  utils.rmFile(...) should be after 
Just to make sure, do you mean:

if utils.isOvirtNode():
  NodeCfg().unpersist(content['path'])
utils.rmFile(content['path'])
Line 323:             if utils.isOvirtNode():
Line 324:                 NodeCfg().unpersist(content['path'])
Line 325: 
Line 326:     def _unprefixAndRemoveSection(self, path):


-- 
To view, visit http://gerrit.ovirt.org/28782
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list