Change in vdsm[master]: domainMonitor: Introduce cancellation points

Federico Simoncelli fsimonce at redhat.com
Mon Jun 16 14:34:00 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: domainMonitor: Introduce cancellation points
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/28721/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 816:     @functools.wraps(meth)
Line 817:     def wrapper(self, *a, **kw):
Line 818:         if self.__canceled__():
Line 819:             raise Canceled()
Line 820:         return meth(self, *a, **kw)
I think we should check this twice so we don't need to trust the next call to also be "cancellable".
Line 821:     return wrapper
Line 822: 
Line 823: 
Line 824: def tobool(s):


-- 
To view, visit http://gerrit.ovirt.org/28721
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a965758736a0b9fa7ac7c2e105bcbbfb04163b8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list