Change in vdsm[master]: virt: drop needless configurable

fromani at redhat.com fromani at redhat.com
Mon Jun 16 13:42:10 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: drop needless configurable
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28808/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 208:         self.sampleBalloon = (
Line 209:             sampling.AdvancedStatsFunction(
Line 210:                 self._sampleBalloon,
Line 211:                 config.getint('vars', 'vm_sample_balloon_interval'),
Line 212:                 2))
I'd like to see a constant here, but mostly for personal taste
Line 213:         self.sampleVmJobs = (
Line 214:             sampling.AdvancedStatsFunction(
Line 215:                 self._sampleVmJobs,
Line 216:                 config.getint('vars', 'vm_sample_jobs_interval'),


-- 
To view, visit http://gerrit.ovirt.org/28808
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e66f18706761ada045799f0f6d488a2c9ef6553
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list