Change in vdsm[master]: vdsm: docstring update

nsoffer at redhat.com nsoffer at redhat.com
Mon Jun 16 11:59:14 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vdsm: docstring update
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/28806/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 30: from fnmatch import fnmatch
Line 31: from SimpleXMLRPCServer import \
Line 32:     SimpleXMLRPCRequestHandler, \
Line 33:     SimpleXMLRPCServer, \
Line 34:     SimpleXMLRPCDispatcher
How is this related to better documentation?
Line 35: from Queue import Queue
Line 36: from StringIO import StringIO
Line 37: from weakref import proxy
Line 38: import SocketServer


Line 49: import platform
Line 50: import select
Line 51: import shutil
Line 52: import signal
Line 53: import socket
Unused import?
Line 54: import stat
Line 55: import threading
Line 56: import time
Line 57: import zombiereaper


-- 
To view, visit http://gerrit.ovirt.org/28806
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list