Change in vdsm[master]: vm: fix guest agent stats field

danken at redhat.com danken at redhat.com
Mon Jun 16 11:21:44 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: fix guest agent stats field
......................................................................


vm: fix guest agent stats field

In commit 068fc28d I mistakenly removed an explicit int() conversion
because I overlooked the code, and thought the result was going to
be an int() anyway.

I was wrong, and the result is a float, which breaks the schema which
dictates the affected field to be an uint.

This patch restores the explicit conversion to make the code compliant
with the schema again.

Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28781
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-by: Martin Sivák <msivak at redhat.com>
Reviewed-by: Kobi Ianko <kobi at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Martin Sivák: Looks good to me, but someone else must approve
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Kobi Ianko: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/28781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab5ab0475e5fdf560ce07cdc1868690d3eceb125
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list