Change in vdsm[master]: misc: Handle Spurious wakeups

nsoffer at redhat.com nsoffer at redhat.com
Sun Jun 15 20:50:20 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: misc: Handle Spurious wakeups
......................................................................


Patch Set 2: Verified-1

Rebasing over http://gerrit.ovirt.org/28683 show that it does not work.

What happens is that the first thread existing the wait loop is entering the barrier, and setting the busy flag again. Then the next threads return to the wait loop, and exit the wait loop only when the second thread exited the barrier.

So you never go into the return False part, where you use the last result.

This can be fixed only in pthreading, so condition wait returns only if notified.

-- 
To view, visit http://gerrit.ovirt.org/28609
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18a23984994d07000f52e9a7676f87f19598ba3f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list