Change in vdsm[master]: misc: Document and test SamplingMethod

Federico Simoncelli fsimonce at redhat.com
Fri Jun 13 17:59:23 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: misc: Document and test SamplingMethod
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/28683/2/tests/miscTests.py
File tests/miscTests.py:

Line 1149: 
Line 1150: class SamplingMethodTests(TestCaseBase):
Line 1151: 
Line 1152:     # Note: this should be long enough so even on very loaded machine, all
Line 1153:     # threads will start within this delay. If this tests fails randomally,
randomly
Line 1154:     # increase this value.
Line 1155:     COMPUTE_SECONDS = 0.2
Line 1156: 
Line 1157:     def setUp(self):


Line 1216:             time.sleep(self.COMPUTE_SECONDS)
Line 1217:             return self.results.pop(0)
Line 1218: 
Line 1219: 
Line 1220: class Thread(object):
I think we should use a less common name (SamplingMethodThread?) and/or make it internal to SamplingMethodTests.
Line 1221: 
Line 1222:     def __init__(self, func):
Line 1223:         self._func = func
Line 1224:         self._thread = threading.Thread(target=self._run)


-- 
To view, visit http://gerrit.ovirt.org/28683
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8da1a220643485e5ce650693d5f3822f2e5fcc05
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list