Change in vdsm[master]: sd: Fix wrong usage of properties on old style class

danken at redhat.com danken at redhat.com
Fri Jun 13 14:56:39 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: sd: Fix wrong usage of properties on old style class
......................................................................


sd: Fix wrong usage of properties on old style class

StorageDomain is an old style class but usess properties, which are
supported *only* for new style classes. This is a nasty corner in Python
where you can define @property on old style classes and they seems to
work in some of the cases, and break in others. The current code happen
to work because we never try to assign to the read only properties.

The patch change StorageDomain to be a new style class, and fix the
tests assuming an old style class.

For more info see:
https://docs.python.org/2.6/library/functions.html#property

Change-Id: I89aee24f1fc472bf6425e4194cea58c7f7b52dc8
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28655
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M tests/getAllVolumesTests.py
M vdsm/storage/sd.py
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified
  Federico Simoncelli: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28655
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89aee24f1fc472bf6425e4194cea58c7f7b52dc8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list