Change in vdsm[master]: netinfo: Move _devinfo out of _*info to avoid passing more p...

osvoboda at redhat.com osvoboda at redhat.com
Fri Jun 13 14:33:16 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: Move _devinfo out of _*info to avoid passing more parameters
......................................................................


Patch Set 2:

(2 comments)

Just some comments.

http://gerrit.ovirt.org/#/c/28700/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: netinfo: Move _devinfo out of _*info to avoid passing more parameters
Line 8: 
Line 9: API change: in _bondinfo, 'options' was changed to 'opts'
Line 10: to mirror 'opts' in _bridgeinfo.
Bonding options were not set in stone or used anyway, this unification should not hurt.
Line 11: 
Line 12: Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5


http://gerrit.ovirt.org/#/c/28700/2/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 775:     if opts:
Line 776:         info['cfg']['BONDING_OPTS'] = ' '.join(
Line 777:             (opt + '=' + val[-1] for (opt, val) in sorted(opts.iteritems())))
Line 778:     elif 'BONDING_OPTS' in info['cfg']:
Line 779:         info['cfg']['BONDING_OPTS'] = ''
Original behaviour kept, even if it is questionable: we might as well delete the key.
Line 780: 
Line 781: 
Line 782: def _cfgBootprotoCompat(netsAndDevices):
Line 783:     """Set network 'cfg' 'BOOTPROTO' for backwards engine compatibility."""


-- 
To view, visit http://gerrit.ovirt.org/28700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b59b9539ee759d06f44e51cf8bbddca52450ac5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list