Change in vdsm[master]: vdsm: Small post-jsonrpc udpates

nsoffer at redhat.com nsoffer at redhat.com
Fri Jun 13 12:49:56 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vdsm: Small post-jsonrpc udpates
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28688/1/lib/vdsm/SecureXMLRPCServer.py
File lib/vdsm/SecureXMLRPCServer.py:

Line 40: 
Line 41: SecureXMLRPCRequestHandler = IPXMLRPCRequestHandler
Line 42: 
Line 43: 
Line 44: class SecureXMLRPCServer(SimpleIPXMLRPCServer):
> You lost me.
kaxmlrpclib import this *module*, but never access the SecureXMLRPCServer *class* which can be deleted.
Line 45:     def __init__(self, addr,
Line 46:                  requestHandler=IPXMLRPCRequestHandler,
Line 47:                  logRequests=True, allow_none=False, encoding=None,
Line 48:                  bind_and_activate=True,


-- 
To view, visit http://gerrit.ovirt.org/28688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aa9021f778a2cd30ef9c19db883fac999563d1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list