Change in vdsm[master]: Adding API methods for CPU limit MOM integration

fromani at redhat.com fromani at redhat.com
Fri Jun 13 10:03:30 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: Adding API methods for CPU limit MOM integration
......................................................................


Patch Set 13: Code-Review-1

(2 comments)

-1 only for visibility

http://gerrit.ovirt.org/#/c/28462/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4653:         except ValueError:
Line 4654:             return self._reportError(key='cpuTuneErr', msg=
Line 4655:                                      'an integer is required for period')
Line 4656:         except libvirt.libvirtError as e:
Line 4657:             return self._reportError(key='cpuTuneErr', msg=e.message)
self._reportException is probably better here
Line 4658:         return {'status': doneCode}
Line 4659: 
Line 4660:     def setCpuTunePeriod(self, period):
Line 4661:         try:


Line 4663:         except ValueError:
Line 4664:             return self._reportError(key='cpuTuneErr',
Line 4665:                                      msg='an integer is required for period')
Line 4666:         except libvirt.libvirtError as e:
Line 4667:             return self._reportError(key='cpuTuneErr', msg=e.message)
ditto
Line 4668:         return {'status': doneCode}
Line 4669: 
Line 4670:     def _reportError(self, key, msg=None):
Line 4671:         """


-- 
To view, visit http://gerrit.ovirt.org/28462
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list