Change in vdsm[master]: Report legacy bond devices instead of actually creating them

danken at redhat.com danken at redhat.com
Fri Jun 13 08:28:03 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Report legacy bond devices instead of actually creating them
......................................................................


Report legacy bond devices instead of actually creating them

Engine <= 3.2 expects to see bonding devices bond0-bond4 predefined on
each host. Therefore, Vdsm creates them on boot, and never deletes them.
This add cumbersome logic, which has lead to bugs.

Instead, this patch simply reports the existence of the 5 expected
bonds, instead of actually creating them.

Note that bond0-bond4 were generated only on el6. Therefore this patch
limits the reports to that operating system.

Bug-Url: https://bugzilla.redhat.com/1064208
Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28455
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
---
M lib/vdsm/netinfo.py
M lib/vdsm/tool/load_needed_modules.py.in
M tests/functional/networkTests.py
M vdsm/caps.py
M vdsm/network/configurators/ifcfg.py
M vdsm/network/configurators/iproute2.py
6 files changed, 43 insertions(+), 22 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28455
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list