Change in vdsm[master]: ioprocess implementation

Federico Simoncelli fsimonce at redhat.com
Thu Jun 12 20:08:35 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: ioprocess implementation
......................................................................


Patch Set 18:

(1 comment)

http://gerrit.ovirt.org/#/c/26967/18/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:

Line 98:         for f in files:
Line 99:             fullpath = os.path.join(path, f)
Line 100:             if _IOProcessOs(self._iop).path.isdir(fullpath):
Line 101:                 try:
Line 102:                     self.cleanupdir(fullpath, False)
shouldn't this be:

 self.cleanupdir(fullpath, ignoreErrors)
Line 103:                 except OSError as e:
Line 104:                     cleanupdir_errors.append(e)
Line 105:             else:
Line 106:                 try:


-- 
To view, visit http://gerrit.ovirt.org/26967
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I132129315c73e880d998a13f84e822a9d4fec2a6
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list