Change in vdsm[master]: LiveMerge: Sync volume chain information after live merge

alitke at redhat.com alitke at redhat.com
Thu Jun 12 12:49:05 UTC 2014


Adam Litke has posted comments on this change.

Change subject: LiveMerge: Sync volume chain information after live merge
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/26636/8/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1797:                 return
Line 1798: 
Line 1799:             dstParent = sdDom.produceVolume(imgUUID, subChain[0]).getParent()
Line 1800:             children = sdDom.produceVolume(imgUUID, subChain[-1]).getChildren()
Line 1801:             if children:
> Should we use a loop here instead?
Since we changed it in the delete patch, we probably should.  I'll cook up a new patchset with this changed.
Line 1802:                 sdDom.produceVolume(imgUUID,
Line 1803:                                     children[0]).setParentMeta(dstParent)
Line 1804: 
Line 1805:     @public


-- 
To view, visit http://gerrit.ovirt.org/26636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib86c19077695354b45818e0186e642ad0e8bc07c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list