Change in vdsm[master]: vm: Collect vm numa node runtime pin information

fromani at redhat.com fromani at redhat.com
Thu Jun 12 15:22:47 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: Collect vm numa node runtime pin information
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/28134/5/tests/numaUtilsTests.py
File tests/numaUtilsTests.py:

Line 111:             fake.guestAgent = FakeGuestAgent()
Line 112:             fake.conf['devices'] = [] if devices is None else devices
Line 113:             fake._guestCpuRunning = runCpu
Line 114:             fake._vmStats = FakeVmStatsThread(fake)
Line 115:             yield fake
> how about importing vmTests and using its FakeVM, and modifying it a bit?
That would be fine for me.
On a later patch we can factor out the shared code in a new module and then everyone will be a bit happier.
Line 116: 
Line 117: 
Line 118: class TestNumaUtils(TestCaseBase):
Line 119: 


-- 
To view, visit http://gerrit.ovirt.org/28134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list