Change in vdsm[master]: sd: unify validateCreateVolumeParams

nsoffer at redhat.com nsoffer at redhat.com
Thu Jun 12 11:45:06 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: sd: unify validateCreateVolumeParams
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/28128/6/vdsm/storage/sd.py
File vdsm/storage/sd.py:

Line 289:         intEncode),
Line 290: }
Line 291: 
Line 292: 
Line 293: class StorageDomain(object):
This an important but unrelated change, and it breaks getAllVolumesTests:
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9161/console

Please rebase this on this patch that fix the failing tests, and explain why
StorageDomain *must* be a new style class, even without this patch.
http://gerrit.ovirt.org/28655

We probably need to evaluate all other classes for this issue.
Line 294:     log = logging.getLogger("Storage.StorageDomain")
Line 295:     storage_repository = config.get('irs', 'repository')
Line 296:     mdBackupVersions = config.get('irs', 'md_backup_versions')
Line 297:     mdBackupDir = config.get('irs', 'md_backup_dir')


-- 
To view, visit http://gerrit.ovirt.org/28128
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I082dc8b382af4a163fd4d10c67e696b1072e6b71
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list