Change in vdsm[master]: replace configure_libvirt.py with python code.

nsoffer at redhat.com nsoffer at redhat.com
Thu Jun 12 10:25:57 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: replace configure_libvirt.py with python code.
......................................................................


Patch Set 28:

(1 comment)

http://gerrit.ovirt.org/#/c/27298/28/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 20: import os
Line 21: import sys
Line 22: import grp
Line 23: import argparse
Line 24: import pwd
Please add a patch *before* this patch, sorting existing imports. This trivial patch can be merged quickly *without* this patch, saving your reviewers a lot of spam from gerrit.
Line 25: import filecmp
Line 26: import rpm
Line 27: import shutil
Line 28: import traceback


-- 
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list