Change in vdsm[master]: misc: Remove mysterious wrong code

Federico Simoncelli fsimonce at redhat.com
Thu Jun 12 09:41:27 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: misc: Remove mysterious wrong code
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28610/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 687
Line 688
Line 689
Line 690
Line 691
> The current code does not make sense.
> If getting the result of the second thread good enough for the rest of the threads, then all of them could use the result of the first thread.

No because in the second run you are guaranteed that the returned value comes *after* what they already preformed before calling the sampling method. In the frist run  you don't know when the first run started.


-- 
To view, visit http://gerrit.ovirt.org/28610
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia803b3169893d7107882b15d0b031c36ec2ef250
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list