Change in vdsm[ovirt-3.4]: dmidecode: Handle missing values.

ybronhei at redhat.com ybronhei at redhat.com
Thu Jun 12 08:29:02 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: dmidecode: Handle missing values.
......................................................................


dmidecode: Handle missing values.

Make all hwInfo fields in API optional, and change property retrieval so
it cannot fail, also, get rid of all keys that contain no actual
information.

The engine will assume that all the missing keys are not available and
report/display an according message (rather than sending 'Not
Specified')

Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1089393
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Signed-off-by: Dima Kuznetsov <dkuznets at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28541
---
M vdsm/dmidecodeUtil.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 13 insertions(+), 11 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Dima Kuznetsov: Verified



-- 
To view, visit http://gerrit.ovirt.org/28541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I979518e1d0c0c882fe98fd5aee43c0d50ab17e14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list