Change in vdsm[master]: vm: Collect vm numa node runtime pin information

fromani at redhat.com fromani at redhat.com
Thu Jun 12 07:26:28 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: Collect vm numa node runtime pin information
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

Good improvements. The code is getting nicer, but we need to address the duplication in tests.
Since we *can* do this in a later patch, it's +1 for me.

http://gerrit.ovirt.org/#/c/28134/5/tests/numaUtilsTests.py
File tests/numaUtilsTests.py:

Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
2014 :)
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


Line 111:             fake.guestAgent = FakeGuestAgent()
Line 112:             fake.conf['devices'] = [] if devices is None else devices
Line 113:             fake._guestCpuRunning = runCpu
Line 114:             fake._vmStats = FakeVmStatsThread(fake)
Line 115:             yield fake
We need to avoid this duplication, by moving this common code in a shared helper.

However, it doesn't make sense to do that within this patch (it is also a bad smell), so either we rebase this patch on top of a new one or provide a follow up patch which factors out the common code.

I'm fine both ways (and I volunteer to do whatever we choose to do), let's just sync up.
Line 116: 
Line 117: 
Line 118: class TestNumaUtils(TestCaseBase):
Line 119: 


-- 
To view, visit http://gerrit.ovirt.org/28134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list