Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade

dougsland at redhat.com dougsland at redhat.com
Thu Jun 12 04:05:00 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
......................................................................


Patch Set 6:

I had a misunderstood your previous comment, because even reading the stderr and printing/logging while executes the upgrade, in the Engine it only shows the messages to webadmin users when the upgrade process is finished. So, I thought I could redirect again stderr to stdout and use communicate().

With vdsm utils using:
 
upgrade_tool = utils.execCmd(["ovirt-node-upgrade", "--iso=/data/updates/ovirt-node-image.iso", "--reboot=0"], sync=False)
<while print stderr>
upgrade_.wait()

I got the same result as in patch rev 5 (http://gerrit.ovirt.org/#/c/28244/5/vdsm_reg/vdsm-upgrade) , keep needed to read stderr and put a wait for the child to get the correct return code.

-- 
To view, visit http://gerrit.ovirt.org/28244
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b997d70a440545497246d1a19d9671b054a56a5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list