Change in vdsm[master]: utils: add isOvirtNode function.
mtayer at redhat.com
mtayer at redhat.com
Wed Jun 11 15:56:53 UTC 2014
mooli tayer has posted comments on this change.
Change subject: utils: add isOvirtNode function.
......................................................................
Patch Set 3:
(1 comment)
--diff jenkins error seems unrelated:
pep8: error: no such option: --diff
sending an email to dcaro
http://gerrit.ovirt.org/#/c/28486/3/vdsm/caps.py
File vdsm/caps.py:
Line 688
Line 689
Line 690
Line 691
Line 692
> Shouldn't we keep this? Like: def isOvirtNode(): return utils.isOvirtNode()
Why do we need it if I replaced usages of this function?
--
To view, visit http://gerrit.ovirt.org/28486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82207f674f9d1854f9fdddd0804de611073a794c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list