Change in vdsm[ovirt-3.4]: Setting enum for isconfigured return value and change overri...

ybronhei at redhat.com ybronhei at redhat.com
Wed Jun 11 13:31:21 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Setting enum for isconfigured return value and change override semantics
......................................................................


Setting enum for isconfigured return value and change override semantics

isconfigured now returns CONFIGURED, NOT_CONFIGURED and NOT_SURE. This
to
ease and clarify the override semantics.
If module returns CONFIGURED it means that also on force vdsm won't need
to
reconfigure it, as the module configured properly. Although if
configured
returns NOT_SURE, it means, vdsm already configured the module, but on
force we desire to override those configuration to defaults.

Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1088805
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28007
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28473
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 56 insertions(+), 47 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28473
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58b2eef787a90073a06caf88b6847f34fbd042ed
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list