Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes

alitke at redhat.com alitke at redhat.com
Wed Jun 11 13:31:06 UTC 2014


Adam Litke has posted comments on this change.

Change subject: LiveMerge: Add support for deleting merged volumes
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/26768/8/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 209:         for childID in self.getChildren():
Line 210:             child = BlockVolume(self.repoPath, self.sdUUID, self.imgUUID,
Line 211:                                 childID)
Line 212:             metaParent = child.getMetaParam(volume.PUUID)
Line 213:             tagParent = child.getParent()
> Since we have setParentMeta and setParentTag it may be clearer to also have
Done
Line 214:             if metaParent != tagParent:
Line 215:                 self.log.debug("Updating stale PUUID LV tag from %s to %s for "
Line 216:                                "volume %s", tagParent, metaParent,
Line 217:                                child.volUUID)


-- 
To view, visit http://gerrit.ovirt.org/26768
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list