Change in vdsm[master]: mounts: Optimize mount loop device resolution

dkuznets at redhat.com dkuznets at redhat.com
Wed Jun 11 13:02:37 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: mounts: Optimize mount loop device resolution
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/28586/2/vdsm/storage/mount.py
File vdsm/storage/mount.py:

Line 110:             return f.read()[:-1]
Line 111: 
Line 112:     # Old kernels might not have the sysfs entry, this is a bit slower and does
Line 113:     # not work on hosts that do support the above method.
Line 114:     mtabTimestamp = os.stat(_ETC_MTAB_PATH).st_mtime
> Please put 114-121 in a separate method and make sure you take a lock as yo
Done
Line 115:     global _loopLookupTimestamp
Line 116:     if _loopLookupTimestamp != mtabTimestamp:
Line 117:         for entry in _iterateMtab():
Line 118:             for opt in entry.fs_mntops:


Line 132:             yield _parseFstabLine(line)
Line 133: 
Line 134: 
Line 135: def _iterMountRecords():
Line 136: 
> Stray newline?
yes
Line 137:     for rec in _iterKnownMounts():
Line 138:         realSpec = _resolveLoopDevice(rec.fs_spec)
Line 139:         if rec.fs_spec == realSpec:
Line 140:             yield rec


-- 
To view, visit http://gerrit.ovirt.org/28586
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54f11786b45782cedd994d52e1e506292132fa47
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list