Change in vdsm[master]: vm: detect migration completed on recovery

fromani at redhat.com fromani at redhat.com
Wed Jun 11 12:36:17 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: detect migration completed on recovery
......................................................................


Patch Set 8:

patch set 9: clean up as much as possible things in _run(); try to address Dan's concern about racy behaviour. This is the safest solution I see right now.

The biggest issue, however, is that this code is too messy. The flows are deeply intertwined and the code is (IMHO) poorly subdivided in methods, then fixing these corner cases leads to even more chaos.

I'm the first in line to cleanup this code, but I'm afraid the patches will end up big and quite painful to verify and review.

-- 
To view, visit http://gerrit.ovirt.org/28511
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I451c2a940693842e9bf7c63ccc117e75026bb11b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list