Change in vdsm[master]: adding API method for blkio limits MOM integration

nsoffer at redhat.com nsoffer at redhat.com
Wed Jun 11 09:57:45 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: adding API method for blkio limits MOM integration
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/28547/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1292:                 raise ValueError('A non-zero total value and non-zero'
Line 1293:                                  ' read/write value for %s_sec can not be'
Line 1294:                                  ' set at the same time' % category)
Line 1295: 
Line 1296:     def _normalizeIoTuneParams(self):
> I'm sorry, I feel that this change should be in. in a separate patch, we're
You are invited to debate on this with Dan.
Line 1297:         ioTuneParams = ('total_bytes_sec', 'read_bytes_sec',
Line 1298:                         'write_bytes_sec', 'total_iops_sec',
Line 1299:                         'write_iops_sec', 'read_iops_sec')
Line 1300:         for key, value in self.specParams['ioTune'].iteritems():


-- 
To view, visit http://gerrit.ovirt.org/28547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43b25627e5365fdd1145a75e91fb5b7714e46aaf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list