Change in vdsm[master]: Refactoring reportError func
fromani at redhat.com
fromani at redhat.com
Wed Jun 11 07:36:11 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: Refactoring reportError func
......................................................................
Patch Set 12:
(1 comment)
http://gerrit.ovirt.org/#/c/28482/12/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4492: self.saveState()
Line 4493: return {'status': doneCode}
Line 4494:
Line 4495: def _reportError(self, key, msg=None):
Line 4496: """
> You fixed the docstring, and this is a good improvement.
and use the one which fits best in any*
Line 4497: Log an error and produce an error status.
Line 4498: """
Line 4499: self.log.exception("Operation failed")
Line 4500: if msg is None:
--
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list