Change in vdsm[master]: Refactoring reportError func

kobi at redhat.com kobi at redhat.com
Wed Jun 11 07:12:25 UTC 2014


Kobi Ianko has posted comments on this change.

Change subject: Refactoring reportError func
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/28482/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4495:     def _reportError(self, key, msg=None):
Line 4496:         """
Line 4497:         Convert an exception to an error status.
Line 4498:         This method should be called only within exception-handling context.
Line 4499:         """
> And yet the very first usage of this method is at line 4475, when self._dom
You are right, and I don't think we should limit the method to only exceptions, 
What do you say on "Log an error and produce an error status." ?
Line 4500:         self.log.exception("Operation failed")
Line 4501:         if msg is None:
Line 4502:             error = errCode[key]
Line 4503:         else:


-- 
To view, visit http://gerrit.ovirt.org/28482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041a662f4fe02f671a7335d7eca84704443f5bee
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list