Change in vdsm[master]: jsonrpc: xmlrpc protocol detection

danken at redhat.com danken at redhat.com
Tue Jun 10 23:11:01 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: xmlrpc protocol detection
......................................................................


Patch Set 5: -Code-Review

(1 comment)

http://gerrit.ovirt.org/#/c/28507/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 257:     """
Line 258:     Code below was part of SimpleXMLRPCServer.SimpleXMLRPCServer.
Line 259:     We need this code here in order to construct our ConnectedTCPServer
Line 260:     which let us provide connected sockets during runtime.
Line 261:     """
> This docstring is useless. It may be needed on the ConnectedTCPServer class
yeah, it's not the best of docstrings. it can be dropped to allow longer rethinking.

All that I absolutely request is a comment:

 # code taken from Python 2.7's SimpleXMLRPCServer.SimpleXMLRPCServer.__init__.
Line 262:     allow_reuse_address = True
Line 263: 
Line 264:     def __init__(self, requestHandler=SimpleXMLRPCRequestHandler,
Line 265:                  logRequests=True, allow_none=False, encoding=None):


-- 
To view, visit http://gerrit.ovirt.org/28507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72819cc0ab5bde0150456263ab7dd1a5e99abfeb
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list