Change in vdsm[master]: jsonrpc: Json processing issues fixed

danken at redhat.com danken at redhat.com
Tue Jun 10 23:01:29 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpc: Json processing issues fixed
......................................................................


jsonrpc: Json processing issues fixed

Number of issues fixed:
- Default value was missing in SP.disconnect
- Host.setupNetworks and Image.download was returning True where as it
should return information according to schema
- Bridge.py did not processed order of optional parameters properly.
For fencing flow second optional parameter is ued which caused the
issue. Fix provide default value for any optional parameters in between.

Change-Id: I33094f3e761c616141f60c190f7deaec08fe1f08
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: http://gerrit.ovirt.org/28505
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/Makefile.am
A tests/bridgeTests.py
M vdsm/API.py
M vdsm/rpc/Bridge.py
4 files changed, 146 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28505
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33094f3e761c616141f60c190f7deaec08fe1f08
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list