Change in vdsm[master]: tests: fix wrong use of assertions

nsoffer at redhat.com nsoffer at redhat.com
Tue Jun 10 22:04:12 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tests: fix wrong use of assertions
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.ovirt.org/#/c/28124/7/tests/functional/storageTests.py
File tests/functional/storageTests.py:

Line 540:         export = line.split(" ", 1)[0]
Line 541:         if fnmatch.fnmatch(export, pathPattern):
Line 542:             try:
Line 543:                 unexportNFS(export)
Line 544:             except TestRunnerError as e:
We don't use e, so don't bind it:

    except TestRunnerError:
        ...
Line 545:                 logging.exception("Failed to unexport NFS entry %s", export)
Line 546:             else:
Line 547:                 shutil.rmtree(export, ignore_errors=True)
Line 548: 


http://gerrit.ovirt.org/#/c/28124/7/tests/testrunner.py
File tests/testrunner.py:

Line 398:     output, error = process.communicate()
Line 399:     if process.returncode != 0:
Line 400:         raise TestRunnerError("subprocess failed: returncode=%s: stderr=%r" %
Line 401:                               (process.returncode, error))
Line 402:     return output
I agree with Dan that this not the time to add subprocess.Popen. Better to use execCmd in this patch (and update the commit message), and send another patch replacing execCmd with subprocess.Popen in runCommand.
Line 403: 
Line 404: 
Line 405: if __name__ == '__main__':
Line 406:     if "--help" in sys.argv:


-- 
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list