Change in vdsm[master]: adding API methods for blkio limits MOM integration

nsoffer at redhat.com nsoffer at redhat.com
Tue Jun 10 17:43:17 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: adding API methods for blkio limits MOM integration
......................................................................


Patch Set 1:

Adding Francesco since he knows this part of the system better then me.

Francesco:
- Do we need the input validation or we can pass the argument to libvirt and count on its input validation?
- Is error handling consistent with other code in this file?

-- 
To view, visit http://gerrit.ovirt.org/28547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43b25627e5365fdd1145a75e91fb5b7714e46aaf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list