Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes
alitke at redhat.com
alitke at redhat.com
Tue Jun 10 13:18:46 UTC 2014
Adam Litke has posted comments on this change.
Change subject: LiveMerge: Add support for deleting merged volumes
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/26768/5/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:
Line 214: self.log.debug("Updating stale PUUID LV tag from %s to %s for "
Line 215: "volume %s", tagParent, metaParent,
Line 216: child.volUUID)
Line 217: child.setParentTag(metaParent)
Line 218: self.recheckIfLeaf()
> I am not thrilled to have this in the loop. We probably want to check this
No problem. That's an easy fix.
Line 219:
Line 220: if not force:
Line 221: self.validateDelete()
Line 222:
--
To view, visit http://gerrit.ovirt.org/26768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list