Change in vdsm[master]: utils: add isOvirtNode function.
danken at redhat.com
danken at redhat.com
Tue Jun 10 11:17:40 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: utils: add isOvirtNode function.
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28486/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1105: sys.exit(-3)
Line 1106:
Line 1107:
Line 1108: @memoized
Line 1109: def isOvirtNode():
please eliminate the same-named function from caps. Take care to fix all users of caps.isOvirtNode to use this new implementation.
Line 1110: return (
Line 1111: os.path.exists('/etc/rhev-hypervisor-release') or
Line 1112: glob.glob('/etc/ovirt-node-*-release')
Line 1113: )
--
To view, visit http://gerrit.ovirt.org/28486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82207f674f9d1854f9fdddd0804de611073a794c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list