Change in vdsm[master]: virt: Filter internal data for getVMList API

Federico Simoncelli fsimonce at redhat.com
Tue Jun 10 09:29:27 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: virt: Filter internal data for getVMList API
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28532/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2534: 
Line 2535:     def status(self):
Line 2536:         # used by API.Global.getVMList
Line 2537:         self.conf['status'] = self.lastStatus
Line 2538:         ret = deepcopy(self.conf)
The entire thing could probably be:

 return dict((k, v) for k, v in a.iteritems() if not k.startswith("_"))
Line 2539:         # Filter out any internal keys
Line 2540:         for k in ret.keys():
Line 2541:             if k.startswith('_'):
Line 2542:                 del ret[k]


-- 
To view, visit http://gerrit.ovirt.org/28532
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39ac6935e5b95912eed42f16871566722316515a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list