Change in vdsm[master]: vm: Collect vm numa node runtime pin information

fromani at redhat.com fromani at redhat.com
Tue Jun 10 08:47:05 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: Collect vm numa node runtime pin information
......................................................................


Patch Set 4:

(1 comment)

AFAIR stats are polled from engine every 15 (fifteen) seconds. And if this is correct (a simple proof: the sample intervalsin the lib/vdsm/config.py* are all multiple of 15), to poll the pin info every 2s will be just useless, because values will get overwritten without engine knowing. This is what I'm concerned about.

http://gerrit.ovirt.org/#/c/28134/4/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 173:         ('vm_sample_vcpu_pin_interval', '2',
Line 174:             'How often should we sample each vcpu runtime pinning to '
Line 175:             'which physical cpu core.'),
Line 176: 
Line 177:         ('vm_sample_vcpu_pin_window', '2', None),
> come to think of it - is there any need in a window here (and for balloon t
I agree we shouldn't need a window here (-surely not for balloon)

However, we cannot in the current form of AdvancedStatsFunction (see vdsm/virt/sampling.py around line 305), because it expects a non-zero window.
I'll fix this in a future patch.
Line 178: 
Line 179:         ('trust_store_path', '@TRUSTSTORE@',
Line 180:             'Where the certificates and keys are situated.'),
Line 181: 


-- 
To view, visit http://gerrit.ovirt.org/28134
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list