Change in vdsm[master]: jsonrpc: Moving rpc related modules in to single package

danken at redhat.com danken at redhat.com
Mon Jun 9 21:03:39 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: Moving rpc related modules in to single package
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

http://gerrit.ovirt.org/#/c/28504/3//COMMIT_MSG
Commit Message:

Line 7: jsonrpc: Moving rpc related modules in to single package
Line 8: 
Line 9: xml and json rpc modules are moved to rpc package.
Line 10: 
Line 11: vdsm-api rpm is not needed anymore so it is removed and there is
this part of the commit message belongs to the previous patch.
Line 12: explicit dependency to have vdsm-jsonrpc rpm.
Line 13: 
Line 14: Change-Id: I83246098e084fe15f45d7fe50df6e4ec33d2aaa1


http://gerrit.ovirt.org/#/c/28504/3/debian/vdsm.install
File debian/vdsm.install:

Line 35: ./usr/share/man/man8/vdsmd.8
Line 36: ./usr/share/vdsm/API.py
Line 37: <<<<<<< HEAD
Line 38: ./usr/share/vdsm/BindingXMLRPC.py
Line 39: =======
rebase glitch
Line 40: >>>>>>> ac9129d... jsonrpc: Moving rpc related modules in to single package
Line 41: ./usr/share/vdsm/addNetwork
Line 42: ./usr/share/vdsm/alignmentScan.py
Line 43: ./usr/share/vdsm/blkid.py


http://gerrit.ovirt.org/#/c/28504/3/vdsm.spec.in
File vdsm.spec.in:

Line 1393: 
Line 1394: %files xmlrpc
Line 1395: %defattr(-, root, root, -)
Line 1396: %dir %{_datadir}/%{vdsm_name}
Line 1397: %{_datadir}/%{vdsm_name}/rpc/BindingXMLRPC.py*
the move has taken place in the previous patch, hasn't it?
Line 1398: 
Line 1399: %files jsonrpc
Line 1400: %doc %{vdsm_name}/rpc/vdsm-api.html
Line 1401: %{_datadir}/%{vdsm_name}/rpc/__init__.py*


http://gerrit.ovirt.org/#/c/28504/3/vdsm/rpc/__init__.py
File vdsm/rpc/__init__.py:

Line 1: #
I like this one
Line 2: # Copyright 2014 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


Line 12: # GNU General Public License for more details.
Line 13: #
Line 14: # You should have received a copy of the GNU General Public License
Line 15: # along with this program; if not, write to the Free Software
Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
but why touch this?
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license


-- 
To view, visit http://gerrit.ovirt.org/28504
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83246098e084fe15f45d7fe50df6e4ec33d2aaa1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list