Change in vdsm[master]: netinfo: Hacked InfiniBand speed.

danken at redhat.com danken at redhat.com
Mon Jun 9 15:27:11 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Hacked InfiniBand speed.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

minor comment. Other than that, it seems fine.

http://gerrit.ovirt.org/#/c/28502/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 274:     return speed
Line 275: 
Line 276: 
Line 277: def _ibHackedSpeed(nicName):
Line 278:     """If the nic is an InfiniBand device, return a speed of 10000 Mbps."""
Please add a comment that this is needed only until kernel BZ#101314 is solved and the infiniband driver reports a proper speed.
Line 279:     with open('/sys/class/net/%s/addr_len' % nicName) as addrFile:
Line 280:         if int(addrFile.read()) == 20:
Line 281:             return 10000
Line 282:     return 0


-- 
To view, visit http://gerrit.ovirt.org/28502
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55089558d59d33da7f44a2f6d7059d291c064f8a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list