Change in vdsm[master]: core: GET requests - use Range header

Federico Simoncelli fsimonce at redhat.com
Mon Jun 9 15:10:58 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: core: GET requests - use Range header
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/28465/3/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:

Line 272:                         httplib.BAD_REQUEST,
Line 273:                         "range in an unsupported format")
Line 274: 
Line 275:                 min = m.group(1)
Line 276:                 if min != '0':
You should also support "" right? (0 by default I think)
Line 277:                     raise self.RequestException(
Line 278:                         httplib.BAD_REQUEST,
Line 279:                         "range first byte position other than 0 isn't "
Line 280:                         "supported")


-- 
To view, visit http://gerrit.ovirt.org/28465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list